On Mon, Oct 09, 2017 at 08:45:41AM -0700, Dan Williams wrote:
> On Mon, Oct 9, 2017 at 1:07 AM, Johannes Thumshirn <[email protected]> wrote:
> > On Sat, Oct 07, 2017 at 08:14:42AM -0700, Dan Williams wrote:
> > [...]
> >
> >> +rxe_cfg stop
> >> +rxe_cfg start
> >> +if ! rxe_cfg status | grep -n rxe0; then
> >> +     rxe_cfg add eth0
> >> +fi
> >
> > Can we maybe skip the dependency on rxe_cfg? All that is needed is modprobe
> > and echo.
> 
> Sure, I'll take a look.

For my NVMe over Soft-RoCE test setup with Rapido [1] I used the following:

modprobe rdma-rxe
echo eth0 > /sys/module/rdma_rxe/parameters/add

> 
> > Also hard coding eth0 might be problematic in this case. This works
> > on your test-setup but surely isn't portable.
> 
> Yes,  which is part of the reason I have this listed under the
> "destructive" tests. Any advice on how to make it portable would be
> appreciated.

Maybe:
ETH=${ETH:-eth0}
echo $ETH > /sys/module/rdma_rxe/parameters/add

Byte,
        Johannes

[1] https://github.com/rapido-linux/rapido/blob/master/nvme_rdma_autorun.sh#L74

-- 
Johannes Thumshirn                                          Storage
[email protected]                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to