On Mon, Oct 9, 2017 at 1:07 AM, Johannes Thumshirn <[email protected]> wrote:
> On Sat, Oct 07, 2017 at 08:14:42AM -0700, Dan Williams wrote:
> [...]
>
>> +rxe_cfg stop
>> +rxe_cfg start
>> +if ! rxe_cfg status | grep -n rxe0; then
>> +     rxe_cfg add eth0
>> +fi
>
> Can we maybe skip the dependency on rxe_cfg? All that is needed is modprobe
> and echo.

Sure, I'll take a look.

> Also hard coding eth0 might be problematic in this case. This works
> on your test-setup but surely isn't portable.

Yes,  which is part of the reason I have this listed under the
"destructive" tests. Any advice on how to make it portable would be
appreciated.
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to