"Gopinath, Thara" <[email protected]> writes: >>> >>>Thara Gopinath <[email protected]> writes: >>> >>>> This patch ensures that sr id is passed as a parameter only to >>>> public APIs in smartreflex.c and other APIs in smartreflex.c >>>> uses the omap_sr strucutres. >>>> >>>> Signed-off-by: Thara Gopinath <[email protected]> >>> >>>Good change, but... >>>
[...] >>> >>>... the class3 layer is still taking SR ID as a parameter and it >>>should also just take an sr_info ptr. > > sr_info is an internal structure for smartreflex driver. The > intention behind this patch is all external API's pass the srid and > internally the driver static APIs take sr_info as parameter. OK, that makes sense. I though I saw the usage of _sr_lookup() inside the class driver which made me think it should just take sr_info. But looking again now, I see it's only using the id. > I did not realize this point till now when I was doing the actual > changes and hence the late reply :-) no worries, thanks for clarifying. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
