> -----Original Message-----
> From: Kevin Hilman [mailto:[email protected]]
> Sent: Saturday, September 04, 2010 2:22 AM
> To: G, Manjunath Kondaiah
> Cc: [email protected]; Cousson, Benoit; Shilimkar, Santosh
> Subject: Re: [PATCH v2 04/11] OMAP3: DMA: HWMOD: Add hwmod
> data structures
>
> Manjunatha GK <[email protected]> writes:
>
> > This patch adds OMAP3 DMA hwmod structures.
>
[..]
> > +
> > +static struct omap_hwmod omap3xxx_dma_system_hwmod = {
> > + .name = "dma",
> > + .class = &omap3xxx_dma_hwmod_class,
> > + .mpu_irqs = omap3xxx_dma_system_irqs,
> > + .mpu_irqs_cnt = ARRAY_SIZE(omap3xxx_dma_system_irqs),
> > + .main_clk = "l3_div_ck",
> > + .slaves = omap3xxx_dma_system_slaves,
> > + .slaves_cnt = ARRAY_SIZE(omap3xxx_dma_system_slaves),
> > + .masters = omap3xxx_dma_system_masters,
> > + .masters_cnt = ARRAY_SIZE(omap3xxx_dma_system_masters),
> > + .dev_attr = &dma_dev_attr,
> > + .omap_chip = OMAP_CHIP_INIT(CHIP_IS_OMAP3430),
> > + .flags = HWMOD_NO_IDLEST,
>
> hmm, I see an ST_DMA bit in CM_IDLEST1_CORE for DMA.
>
> Having this also masks the fact that you haven't filled out the
> .prcm.omap2 fields of the hwmod, at least the idlest ones are needed
> here.
Ok. I will introduce .prcm entries as:
.prcm = {
.omap2 = {
.prcm_reg_id = 1,
.module_bit = OMAP3430_ST_SDMA_SHIFT,
.module_offs = CORE_MOD,
.idlest_reg_id = 1,
.idlest_idle_bit = OMAP3430_ST_SDMA_SHIFT,
},
}
.flags = HWMOD_SET_DEFAULT_CLOCKACT,
-Manjunath
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
