Kevin, > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of G, > Manjunath Kondaiah > Sent: Tuesday, September 07, 2010 5:17 PM > To: Kevin Hilman > Cc: [email protected]; Cousson, Benoit; Shilimkar, Santosh > Subject: RE: [PATCH v2 07/11] OMAP2/3/4: DMA: HWMOD: Device > registration > > > > > -----Original Message----- > > From: Kevin Hilman [mailto:[email protected]] > > Sent: Saturday, September 04, 2010 2:30 AM > > To: G, Manjunath Kondaiah > > Cc: [email protected]; Cousson, Benoit; Shilimkar, Santosh > > Subject: Re: [PATCH v2 07/11] OMAP2/3/4: DMA: HWMOD: Device > > registration > > > > Manjunatha GK <[email protected]> writes: > > > > > This patch converts omap2/3/4 dma driver into platform devices > > > through using omap hwmod, omap device and runtime pm frameworks. > > [..] > > > > + > > > +#define dma_read(reg) > > \ > > > +({ > > \ > > > + u32 __val; > > \ > > > + __val = __raw_readl(dma_base + OMAP_DMA4_##reg); > > \ > > > + __val; > > \ > > > +}) > > > + > > > +#define dma_write(val, reg) > > \ > > > +({ > > \ > > > + __raw_writel((val), dma_base + OMAP_DMA4_##reg); > > \ > > > +}) > > > > I know these are copy paste from the original code, but > please convert > > into static inline functions. > > Ok.
How static inline functions are better than this? -Manjunath -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
