> +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE) The ifdefs here aren't really saving much... >>> In the same file board-rx51-peripheral.c,Under these rx51_display_device is defined as extern and also in board-rx51-video.c the under same #defines Complete display functionality is implemented currently so used not to break compilation when #defines are not enabled .
>>.dev_name is preferred, though I'm not sure if we'll ever get round to phasing out plain dev. >>>>It is difficult to modify currently. ________________________________________ From: ext Mark Brown [[email protected]] Sent: Thursday, November 25, 2010 6:11 PM To: Bhavanarayana Srikar.1 (EXT-Elektrobit/Helsinki) Cc: [email protected]; [email protected]; [email protected] Subject: Re: [PATCH 2/2] enabled vdda_dac regulator support tvout on rx51 On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote: > +static struct regulator_consumer_supply rx51_vdac_supply[] = { > + { > +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE) The ifdefs here aren't really saving much... > + .supply = "vdda_dac", > + .dev = &rx51_display_device.dev, dev_name is preferred, though I'm not sure if we'll ever get round to phasing out plain dev. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
