On 11/25/2010 06:11 PM, ext Mark Brown wrote:
> On Thu, Nov 25, 2010 at 05:52:23PM +0200, Srikar wrote:
>
>> +static struct regulator_consumer_supply rx51_vdac_supply[] = {
>> +    {
>> +#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
> The ifdefs here aren't really saving much...
Currently rx51_display_device is defined under same
ifdefs(CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE)
 as extern and also in board-rx51-video.c display devices are under same
ifdefs,So used to  not
break compilation when CONFIG_FB_OMAP2,CONFIG_FB_OMAP2_MODULE not defined.
>> +            .supply = "vdda_dac",
>> +            .dev    = &rx51_display_device.dev,
> dev_name is preferred, though I'm not sure if we'll ever get round to
> phasing out plain dev.
Currently difficult to use .dev_name .
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to