Re: [PATCHv5 01/11] OMAP: prcm: switch to a chained IRQ handler mechanism

[Felipe Balbi]

Hi,

On Tue, Jul 05, 2011 at 01:27:47PM +0300, Tero Kristo wrote:
> @@ -854,20 +802,35 @@ static int __init omap3_pm_init(void)
>       /* XXX prcm_setup_regs needs to be before enabling hw
>        * supervised mode for powerdomains */
>       prcm_setup_regs();
> +     ret = omap_prcm_irq_init();
> +     if (ret) {
> +             pr_err("omap_prcm_irq_init() failed with %d\n", ret);
> +             goto err_prcm_irq_init;
> +     }
> +
> +     prcm_wkup_irq = omap_prcm_event_to_irq("wkup");
> +     prcm_io_irq = omap_prcm_event_to_irq("io");
> +
> +     ret = request_irq(prcm_wkup_irq, _prcm_int_handle_wakeup,
> +                     IRQF_NO_SUSPEND | IRQF_DISABLED, "prcm_wkup", NULL);

IRQF_DISABLED shouldn't be used anymore ;-)

<linux/interrupt.h>:

 45  * IRQF_DISABLED - keep irqs disabled when calling the action handler.
 46  *                 DEPRECATED. This flag is a NOOP and scheduled to be 
removed


-- 
balbi

signature.asc
Description: Digital signature