On Fri, 2011-07-15 at 18:40 +0200, Todd Poynor wrote:
> On Tue, Jul 05, 2011 at 01:27:47PM +0300, Tero Kristo wrote:
> > Introduce a chained interrupt handler mechanism for the PRCM
> > interrupt, so that individual PRCM event can cleanly be handled by
> > handlers in separate drivers. We do this by introducing PRCM event
> > names, which are then matched to the particular PRCM interrupt bit
> > depending on the specific OMAP SoC being used.
> >
> > arch/arm/mach-omap2/prcm.c implements the chained interrupt mechanism
> > itself, with individual PRCM events for OMAP3 and OMAP4 being
> > described in arch/arm/mach-omap2/prcm3xxx.c and
> > arch/arm/mach-omap2/prcm4xxx.c respectively. At initialization time,
> > the set of PRCM events is filtered against the SoC on which we are
> > running, keeping only the ones that are actually useful. All the logic
> > is written to be generic with regard to OMAP3/OMAP4, even though OMAP3
> > has single PRCM event registers and OMAP4 has two PRCM event
> > registers.
> >
> ...
> > +
> > + prcm_wkup_irq = omap_prcm_event_to_irq("wkup");
> > + prcm_io_irq = omap_prcm_event_to_irq("io");
>
>
> Should check error return for both.
Not needed, the next calls for request_irq will fail if these do not
succeed (attempting to request irq with invalid number.)
Rest of the return value checks I can add to the next version of this
set.
>
> > +
> > + ret = request_irq(prcm_wkup_irq, _prcm_int_handle_wakeup,
> > + IRQF_NO_SUSPEND | IRQF_DISABLED, "prcm_wkup", NULL);
> >
>
> ...
> > + for (i = 0; i <= max_irq / 32; i++) {
> > + gc = irq_alloc_generic_chip("PRCM", 1,
> > + irq_setup->base_irq + i * 32, NULL, handle_level_irq);
> > +
>
> Should check NULL return for out of memory.
>
> > + ct = gc->chip_types;
>
> ...
> > + /* Copy setup from __initdata section */
> > + irq_setup = kmalloc(sizeof(struct omap_prcm_irq_setup), GFP_KERNEL);
>
>
> Check NULL return.
>
> > + memcpy(irq_setup, setup, sizeof(struct omap_prcm_irq_setup));
> > +
> > + irqs = kmalloc(sizeof(struct omap_prcm_irq) *
> > + setup->num_irqs, GFP_KERNEL);
>
> Check NULL return.
>
> > + memcpy(irqs, setup->irqs, sizeof(struct omap_prcm_irq) *
> > + setup->num_irqs);
>
>
> Todd
Texas Instruments Oy, Tekniikantie 12, 02150 Espoo. Y-tunnus: 0115040-6.
Kotipaikka: Helsinki
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
