Hi, > On Fri, Aug 26, 2011 at 04:41:48PM +0530, Ajay Kumar Gupta wrote: > > @@ -57,6 +58,10 @@ config USB_MUSB_AM35X > > tristate "AM35x" > > depends on ARCH_OMAP > > > > +config USB_MUSB_TI81XX > > + bool "TI81XX" > > + depends on SOC_OMAPTI81XX > > this *must* be tristate. I can't emphasize enough how important this > is.
Ok. > > > diff --git a/drivers/usb/musb/musb_core.c > > b/drivers/usb/musb/musb_core.c index 20a2873..07f3faf 100644 > > --- a/drivers/usb/musb/musb_core.c > > +++ b/drivers/usb/musb/musb_core.c > > @@ -1014,7 +1014,9 @@ static void musb_shutdown(struct > platform_device *pdev) > > || defined(CONFIG_USB_MUSB_OMAP2PLUS) \ > > || defined(CONFIG_USB_MUSB_OMAP2PLUS_MODULE) \ > > || defined(CONFIG_USB_MUSB_AM35X) \ > > - || defined(CONFIG_USB_MUSB_AM35X_MODULE) > > + || defined(CONFIG_USB_MUSB_AM35X_MODULE) \ > > + || defined(CONFIG_USB_MUSB_TI81XX) \ > > + || defined(CONFIG_USB_MUSB_TI81XX_MODULE) > > we really need to find a better way to handle this :-( How about passing the mode info from musb_config (musb->config->fifo_mode), same way as musb->config->fifo_cfg Infact I think, we can kill musb->config->fifo_cfg and have only musb->config->mode as in this way all the fifo tables will be at one place and should help in maintenance. > > > diff --git a/drivers/usb/musb/ti81xx.c b/drivers/usb/musb/ti81xx.c > new > > file mode 100644 index 0000000..f95774e > > --- /dev/null > > +++ b/drivers/usb/musb/ti81xx.c > > I still think this should be part of am35x.c It really look like they > are very similar. Wrapper registers are different but I will see on this and provide you details On how the merged file would look like. I am afraid that we may have to use Either #ifdef or cpu_is_xxx(). > > on monday I'll read the rest of the file. Ok. Ajay > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
