Re: [PATCH 12/15] ARM: OMAP4+: CPUidle: Cleanup idle driver for OMAP5 support

[Nishanth Menon]

On 17:41-20130301, Santosh Shilimkar wrote:
> diff --git a/arch/arm/mach-omap2/cpuidle44xx.c 
> b/arch/arm/mach-omap2/cpuidle44xx.c
> index 9de47a7..df81243 100644
> --- a/arch/arm/mach-omap2/cpuidle44xx.c
> +++ b/arch/arm/mach-omap2/cpuidle44xx.c
[...]
> @@ -234,11 +237,12 @@ int __init omap4_idle_init(void)
>       on_each_cpu(omap_setup_broadcast_timer, NULL, 1);
>  
>       for_each_cpu(cpu_id, cpu_online_mask) {
> -             dev = &per_cpu(omap4_idle_dev, cpu_id);
> +             dev = &per_cpu(omap_idle_dev, cpu_id);
>               dev->cpu = cpu_id;
>  #ifdef CONFIG_ARCH_NEEDS_CPU_IDLE_COUPLED
>               dev->coupled_cpus = *cpu_online_mask;
>  #endif
> +             state_ptr = &omap4_idle_data[0];
minor:
why initialize it twice (cpu0 and cpu1) to the same pointer in each of
the for_each_cpu loop? you could move it maybe just before the loop?
>               cpuidle_register_driver(&omap4_idle_driver);
>  
>               if (cpuidle_register_device(dev)) {
Otherwise,
Acked-by: Nishanth Menon <n...@ti.com>
-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html