On 08/23/2013 12:39 AM, Tomasz Figa wrote: >> Documentation/devicetree/bindings/media/samsung-s5k5baf.txt create mode >> > 100644 drivers/media/i2c/s5k5baf.c >> > >> > diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt >> > b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt new file >> > mode 100644 >> > index 0000000..d680d99 >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt >> > @@ -0,0 +1,59 @@ >> > +Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor with embedded SoC ISP >> > +-------------------------------------------------------------------- >> > + >> > +Required properties: >> > + >> > +- compatible : "samsung,s5k5baf"; >> > +- reg : I2C slave address of the sensor; > > Can this sensor have an aribitrary slave address or only a set of well > known possible addresses (e.g. listed in documentation)?
According to the datasheet it can have one of two I2C addresses (0x2D, 0x3C), selectable by a dedicated pin. Also they may be revisions of the device that use different addresses. I believe what addresses are possible is out of scope of this binding document. We can handle whatever is used. >> > +- vdda-supply : analog power supply 2.8V (2.6V to 3.0V); >> > +- vddreg-supply : regulator input power supply 1.8V (1.7V to > 1.9V) >> > + or 2.8V (2.6V to 3.0); >> > +- vddio-supply : I/O power supply 1.8V (1.65V to 1.95V) >> > + or 2.8V (2.5V to 3.1V); >> > +- stbyn-gpios : GPIO connected to STDBYN pin; >> > +- rstn-gpios : GPIO connected to RSTN pin; > > Both GPIOs above have names suggesting that they are active low. I wonder > how the GPIO flags cell is interpreted here, namely the polarity bit. That's a good point. The GPIO flags are be used to specify active state of the GPIO. Some sensors happen to use different active state for those signals. It's not the case for this sensor though AFAICT. Anyway IMO it would be better to name those gpios: "stby-gpios", "rst-gpios" in case there appear revisions that have their pin named STDBY or RST rather than STDBYN, RSTN. That seems rather unlikely though, but since there are devices to which that could apply I think for consistency it might be better to remove indication of polarity from the GPIO names. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
