On Mon, 2005-03-28 at 15:58 -0600, James Bottomley wrote: > On Mon, 2005-03-21 at 10:41 -0800, Mark Haverkamp wrote: > > + Adaptec 2130S
That was in the TODO file I think. There isn't a new card supported in this patch set. > > Why are we getting updated card support in an endian cleanup patch? > > > +/* > > + * Some configurations of BE Linux have writel and readl automatically > > perform > > + * byte swapping, and some configurations (embedded) do not. Typically > > + * AAC_IO_USES_CPU_ORDER needs to be defined since most BE ports are > > working > > + * with drivers that have not been coded to support BE. > > + */ > > +#define AAC_IO_USES_CPU_ORDER 1 > > +#ifdef AAC_IO_USES_CPU_ORDER > > +# define aac_io_le32_to_cpu > > +# define aac_io_cpu_to_le16 > > +# define aac_io_cpu_to_le32 > > +#else > > +# define aac_io_le32_to_cpu le32_to_cpu > > +# define aac_io_cpu_to_le16 cpu_to_le16 > > +# define aac_io_cpu_to_le32 cpu_to_le32 > > +#endif > > What exactly is this for? I know of no platforms that implement readl > and friends incorrectly, so all of this should be unnecessary. I wondered about this. Mark S. thought that there were some. If there aren't, I can remove all that code. Mark. > > James > -- Mark Haverkamp <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
