On Tue, Aug 31, 1999 at 05:58:43AM -0400, Doug Ledford wrote:
> Let me demonstrate, by means of an actuall aic7xxx setup line I have put into
> my lilo.conf in the past, why interpreting commas in a string variable is
> wrong and how the suggestion you made would break my parser:
>
>
>append="aic7xxx=verbose:0x9939,tag_info:{,{32,32,32,32,32,32,32,32},{,,,,32,32,32,32,32,32},{0,0}},panic_on_abort"
>
> Now, if insmod wants to put those into individual strings then I have to turn
> around and cat them all back together and re-insert the commas in order to
> make my parser work. In general, the format my parser uses allows a person to
> do set a lot of variables with a minumum of effort. Far less effort than the
> typical insmod way of doing things which would translate the above line to:
>
> insmod aic7xxx aic7xxx_verbose=0x9939 aic7xxx_panic_on_abort=1
>
>aic7xxx_tag_info=255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,32,32,32,32,32,32,32,32,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,32,32,32,32,32,32,255,255,255,255,255,255,0,0
OK, the insmod parser should respect quotes and braces {}.
What about adding this functionality to
(a) the kernel
(b) insmod
and get rid of a lot of parsing stuff in the drivers?
I think Keith Owens (modutils maintainer) will agree with that; I don't know
about Linus.
Regards,
--
Kurt Garloff <[EMAIL PROTECTED]> Wuppertal, FRG
PGP2 key: See mail header, key servers Linux kernel development
SuSE GmbH, N�rnberg, FRG SCSI drivers: tmscsim(DC390), DC395
PGP signature
