On Fri, Jan 31, 2014 at 12:07 +0200, Baruch Siach wrote:
>
> Signed-off-by: Baruch Siach <[email protected]>
> ---
> Documentation/devicetree/bindings/spi/spi-dw.txt | 24
> ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/spi-dw.txt
You introduce a new binding, but don't Cc: the devicetree list
for review.
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-dw.txt
> @@ -0,0 +1,24 @@
> +Synopsys DesignWare SPI master
> +
> +Required properties:
> +- compatible: should be "snps,designware-spi"
> +- #address-cells: see spi-bus.txt
> +- #size-cells: see spi-bus.txt
> +- reg: address and length of the spi master registers
> +- interrupts: should contain one interrupt
> +- clocks: spi clock phandle
> +- num-cs: see spi-bus.txt
You may want to check Mark Rutland's replies in the DT list
archives with his nits about speaking of phandles only where
specifiers are involved as well, and how he several times
suggested improved descriptions that you can adopt or copy.
Is 'num-cs' really required and not optional? (It may be, I'm
just asking. Given that there has not been a binding before,
there is no compatibility issue either.)
> +
> +Optional properties:
> +- cs-gpios: see spi-bus.txt
> +
> +Example:
> +
> +spi: spi@4020a000 {
> + compatible = "snps,designware-spi";
> + interrupts = <11 1>;
> + reg = <0x4020a000 0x1000>;
> + clocks = <&pclk>;
> + num-cs = <2>;
> + cs-gpios = <&banka 0 0>;
> +};
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected]
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
