Hi Gerhard, Thanks for reviewing.
On Sun, Feb 02, 2014 at 01:23:20PM +0100, Gerhard Sittig wrote: > On Fri, Jan 31, 2014 at 12:07 +0200, Baruch Siach wrote: > > > > Signed-off-by: Baruch Siach <[email protected]> > > --- > > Documentation/devicetree/bindings/spi/spi-dw.txt | 24 > > ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/spi/spi-dw.txt > > You introduce a new binding, but don't Cc: the devicetree list > for review. I wanted to do that but forgot. > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/spi-dw.txt > > @@ -0,0 +1,24 @@ > > +Synopsys DesignWare SPI master > > + > > +Required properties: > > +- compatible: should be "snps,designware-spi" > > +- #address-cells: see spi-bus.txt > > +- #size-cells: see spi-bus.txt > > +- reg: address and length of the spi master registers > > +- interrupts: should contain one interrupt > > +- clocks: spi clock phandle > > +- num-cs: see spi-bus.txt > > You may want to check Mark Rutland's replies in the DT list > archives with his nits about speaking of phandles only where > specifiers are involved as well, and how he several times > suggested improved descriptions that you can adopt or copy. I've see one of these messages last week. I'll try to look them up and update the wording. If you have a pointer to a properly written in-tree 'clocks' description please let me know. > Is 'num-cs' really required and not optional? (It may be, I'm > just asking. Given that there has not been a binding before, > there is no compatibility issue either.) Yes. With this version of the series 'num-cs' is mandatory for the DT case. In the non-DT case the deriver defaults to 4 as before. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - [email protected] - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
