Hi,

On 01/24/2014 04:38 AM, Chen-Yu Tsai wrote:

<snip>

Quick update, I've just tested:
https://github.com/wens/linux/commits/wip/sunxi-next-wifi

About this, I would like to move WiFi power control to a regulator,
and controlled by sunxi-mci via vmmc-supply (not supported ATM)

Actually the sunxi-mci.c driver already has support for an optional
regulator called vmmc.

I like this idea, I've done a version of the dt patch using a regulator
instead of rfkill here:
https://github.com/jwrdegoede/linux-sunxi/commit/8d200113b573549cdcdc1b2d5a5a1cad15cfbe07

This works as advertised and IMHO is the better solution.

<snip>

About the oob interrupt stuff not working, AFAIK you should set a pinctrl
function (not input, but a function like mmc is a function) on the pin in
question
for it to work as external interrupt, I believe you're not doing so in your
dts.

The pinctrl driver seems to set the function when the interrupt is enabled.
Unfortunately we don't have any documentation/examples on how to use them.
I will look into that later.

Hmm, but you also have a pinctrl entry in the dts setting it up as gpio-input,
maybe that conflicts ?

Off topic but, is the USB PHY driver final? I believe there's an issue
in the probe error checking code:

https://github.com/wens/linux/commit/349b8903e8909455d6f91fbad046fddc2d9326a5

No, I need to do another revision and send that upstream, I hope to do so
one of the coming days.

Regards,

Hans

--
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to