Hi,
On 02/07/2014 05:14 PM, Ian Campbell wrote:
This is the result of my afternoons hacking at the urlab hacklab in
Brussels before FOSDEM, thanks for hosting us guys!
This uses the existing ahci platform support in u-boot. Most of the
siunxi specific code comes from the Linux platform patches.
I've tested this only on cubietruck.
Hmm, I notice that you unconditionally define CONFIG_SUNXI_AHCI for
all sunxi boards. This is very wrong for sun5i since there never is
an AHCI controller there, wrong for sun4i since you've not added
any sata clock setup for sun4i, and somewhat wrong for sun7i since
there enabling it only makes sense on boards which have a sata connector.
Can you please respin this patch-set and make the enabling of AHCI done
something through boards.cfg ?
With that fixed I think it looks good, and if there are no objections I'll
happily merge a fixed version into u-boot-sunxi.
Thanks,
Hans
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
