On Fri, 27 Oct 2023 16:37:29 -0700 Song Liu <[email protected]> wrote: > On Fri, Oct 27, 2023 at 4:31 PM Andrii Nakryiko <[email protected]> wrote: > > > > Recent changes to count number of matching symbols when creating > > a kprobe event failed to take into account kernel modules. As such, it > > breaks kprobes on kernel module symbols, by assuming there is no match. > > > > Fix this my calling module_kallsyms_on_each_symbol() in addition to > > kallsyms_on_each_match_symbol() to perform a proper counting. > > > > Cc: Francis Laniel <[email protected]> > > Cc: [email protected] > > Cc: Masami Hiramatsu <[email protected]> > > Cc: Steven Rostedt <[email protected]> > > Fixes: b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func > > matches several symbols") > > Signed-off-by: Andrii Nakryiko <[email protected]> > > Acked-by: Song Liu <[email protected]>
Good catch! Thanks! -- Masami Hiramatsu (Google) <[email protected]>
