On Mon, Mar 4, 2024 at 4:24 PM Eric Dumazet <[email protected]> wrote: > > On Thu, Feb 29, 2024 at 6:10 PM Jason Xing <[email protected]> wrote: > > > > From: Jason Xing <[email protected]> > > > > Prio to this patch, the trace function doesn't print addresses > > which might be forgotten. As we can see, it already fetches > > those, use it directly and it will print like below: > > > > ...tcp_retransmit_skb: skbaddr=XXX skaddr=XXX family=AF_INET... > > It was not forgotten, but a recommendation from Alexei > > https://yhbt.net/lore/all/[email protected]/
Thanks, Eric. Oh, good to see the old threads. I have to change the description. The other reason why I chose to add address messages is we do have some useful information when using trace ss another thread[1] does: it also ships the trace with address printing. [1]: https://lore.kernel.org/netdev/20240304034632.GA21357@didi-ThinkCentre-M920t-N000/ Thanks, Jason
