On Tue, 26 Mar 2024 12:08:01 +0100 Paolo Abeni wrote:
> > -   TP_PROTO(const struct sock *sk, const struct sk_buff *skb),
> > +   TP_PROTO(
> > +           const struct sock *sk,
> > +           const struct sk_buff *skb,
> > +           void *location),  
> 
> Very minor nit: the above lines should be aligned with the open
> bracket.

Yes, and a very odd way of breaking it up. Empty line after ( but
) not on a separate line.

> No need to repost just for this, but let's wait for Eric's feedback.

Erring on the side of caution I'd read this:
https://lore.kernel.org/all/CANn89iKK-qPhQ91Sq8rR_=KDWajnY2=et2bujdsgoqk4wxf...@mail.gmail.com/
as lukewarm towards tp changes. Please repost if you think otherwise
(with the formatting fixed)
-- 
pw-bot: cr

Reply via email to