> When I said "If you feel the need to put them in a special group, this > is fine by me.", > this was really about partitioning the existing enum into groups, if > you prefer having a group of 'RES reasons'
Are you suggesting copying what we need from enum skb_drop_reason{} to enum sk_rst_reason{}? Why not reusing them directly. I have no idea what the side effect of cast conversion itself is? If __not__ doing so (copying reasons one by one), for passive rests, we can totally rely on the drop reason, which means if we implement more reasons for skb drop happening in reset cases, we don't need to handle reset cases over and over again (like adding rst reasons just after newly added drop reasons if without cast conversions). It's easier to maintain the reset reason part if we can apply the current patch series. Thank you.