Hi Steven,

Thanks for the analysis!

On Fri, Oct 11, 2024 at 6:00 PM Steven Rostedt <[email protected]> wrote:
>
> On Fri, 11 Oct 2024 08:25:29 -0700
> syzbot <[email protected]> wrote:
>
> > Hello trace maintainers/developers,
> >
> > This is a 31-day syzbot report for the trace subsystem.
> > All related reports/information can be found at:
> > https://syzkaller.appspot.com/upstream/s/trace
> >
> > During the period, 1 new issues were detected and 0 were fixed.
> > In total, 10 issues are still open and 38 have been fixed so far.
> >
> > Some of the still happening issues:
> >
> > Ref Crashes Repro Title
> > <1> 34      Yes   INFO: task hung in blk_trace_ioctl (4)
> >                   
> > https://syzkaller.appspot.com/bug?extid=ed812ed461471ab17a0c
>
> If you check the maintainers file, blktrace.c has:
>
> BLOCK LAYER
> M:      Jens Axboe <[email protected]>
> L:      [email protected]

Judging by MAINTAINERS and ./scripts/get_maintainer.pl,
kernel/trace/blktrace.c belongs to both "BLOCK LAYER" and "TRACING".

$ ./scripts/get_maintainer.pl kernel/trace/blktrace.c
< ... >
[email protected] (open list:BLOCK LAYER)
[email protected] (open list:TRACING)


>
>
>
> > <2> 32      Yes   WARNING in bpf_get_stack_raw_tp
> >                   
> > https://syzkaller.appspot.com/bug?extid=ce35de20ed6652f60652
>
> bpf_trace.c has:
>
> M:      Alexei Starovoitov <[email protected]>
> M:      Daniel Borkmann <[email protected]>
> M:      Andrii Nakryiko <[email protected]>
> R:      Martin KaFai Lau <[email protected]>
> R:      Eduard Zingerman <[email protected]>
> R:      Song Liu <[email protected]>
> R:      Yonghong Song <[email protected]>
> R:      John Fastabend <[email protected]>
> R:      KP Singh <[email protected]>
> R:      Stanislav Fomichev <[email protected]>
> R:      Hao Luo <[email protected]>
> R:      Jiri Olsa <[email protected]>
> L:      [email protected]

Same for kernel/trace/bpf_trace.c:

$ ./scripts/get_maintainer.pl kernel/trace/bpf_trace.c
< ... >
Matt Bobrowski <[email protected]> (maintainer:BPF [SECURITY &
LSM] (Security Audit and Enforc...)
Steven Rostedt <[email protected]> (maintainer:TRACING)

>
> > <3> 13      Yes   WARNING in get_probe_ref
> >                   
> > https://syzkaller.appspot.com/bug?extid=8672dcb9d10011c0a160
> > <4> 6       Yes   INFO: task hung in blk_trace_remove (2)
> >                   
> > https://syzkaller.appspot.com/bug?extid=2373f6be3e6de4f92562
> > <5> 4       Yes   possible deadlock in __mod_timer (4)
> >                   
> > https://syzkaller.appspot.com/bug?extid=83a876aef81c9a485ae8
>
> None of these look like they are tracing infrastructure related.

Like get_maintainer.pl, syzbot relies on the MAINTAINERS file to
attribute bugs to the individual kernel subsystems. If several ones
are suitable, the bug is assigned several labels at once. It's now
actually the case for all open "trace" findings:

https://syzkaller.appspot.com/upstream/s/trace

(FWIW it's also possible to manually overwrite these labels and remove
specific bugs from the monthly reports).

I could make syzbot set "trace" only if there's no other good
candidate, but I wonder if that could hide the findings in the trace
infrastructure that manifested themselves in some specific traced
subsystem.

-- 
Aleksandr

>
> -- Steve
>
>
> >
> > ---
> > This report is generated by a bot. It may contain errors.
> > See https://goo.gl/tpsmEJ for more information about syzbot.
> > syzbot engineers can be reached at [email protected].
> >
> > To disable reminders for individual bugs, reply with the following command:
> > #syz set <Ref> no-reminders
> >
> > To change bug's subsystems, reply with:
> > #syz set <Ref> subsystems: new-subsystem
> >
> > You may send multiple commands in a single email message.
>

Reply via email to