On Thu, 17 Oct 2024 06:58:30 +0000
"Zhuo, Qiuxu" <[email protected]> wrote:

> When running the check below: 
> 
>     ${LINUX}/scripts/checkpatch.pl --strict  <this patch> 
> 
> it complains:
> 
>     CHECK: Macro argument 'el_size' may be better as '(el_size)' to avoid 
> precedence issues
>     #36: FILE: include/trace/stages/stage3_trace_output.h:123:
>     +#define __print_dynamic_array(array, el_size)                          \
>     +       ({                                                              \
>     +               __print_array(__get_dynamic_array(array),               \
>     +                             __get_dynamic_array_len(array) / el_size, \
>     +                             el_size);                                 \
>     +       })

For once I actually agree with checkpatch in an include/trace file.

I can send another version for you.

-- Steve

Reply via email to