On Mon, 21 Oct 2024 11:44:42 +0200 Jean-Michel Hautbois <[email protected]> wrote:
> The TRACE_IRQFLAGS_SUPPORT requires the architecture to call > trace_hardirqs_off() when interrupts are disabled and > trace_hardirqs_on() when they are enabled. > Add those calls to do_IRQ function. > > Signed-off-by: Jean-Michel Hautbois <[email protected]> > --- > arch/m68k/Kconfig | 1 + > arch/m68k/kernel/irq.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig > index > cc26df907bfe3c8143a931d259eceabb16af7411..ab3375475721fa63418c40d4ba6ac76679ebc77d > 100644 > --- a/arch/m68k/Kconfig > +++ b/arch/m68k/Kconfig > @@ -39,6 +39,7 @@ config M68K > select OLD_SIGSUSPEND3 > select UACCESS_MEMCPY if !MMU > select ZONE_DMA > + select TRACE_IRQFLAGS_SUPPORT > > config CPU_BIG_ENDIAN > def_bool y > diff --git a/arch/m68k/kernel/irq.c b/arch/m68k/kernel/irq.c > index > 9ab4f550342e5de11c528f55781432675ffd66bf..74cf60ebbc4bca51f3caa4046dbd2bdb02355711 > 100644 > --- a/arch/m68k/kernel/irq.c > +++ b/arch/m68k/kernel/irq.c > @@ -21,9 +21,11 @@ asmlinkage void do_IRQ(int irq, struct pt_regs *regs) > { > struct pt_regs *oldregs = set_irq_regs(regs); > > + trace_hardirqs_off(); > irq_enter(); > generic_handle_irq(irq); > irq_exit(); > + trace_hardirqs_on(); This part of the patch shouldn't be needed because those shoudl be called by irq_enter() and irq_exit(). Does this not work if you don't have these? -- Steve > > set_irq_regs(oldregs); > } >
