On Thu, 7 Nov 2024 at 16:34, Steven Rostedt <rost...@goodmis.org> wrote: ... > > + TP_PROTO(struct task_struct *task, int option, unsigned long arg2, > > unsigned long arg3, > > + unsigned long arg4, unsigned long arg5), > > + > > + TP_ARGS(task, option, arg2, arg3, arg4, arg5), > > + > > + TP_STRUCT__entry( > > + __string( comm, task->comm ) > > The question is, do we really need comm? From your example, it's redundant: > > test-484 [000] ..... 631.748104: task_prctl_unknown: comm=test > option=1234 arg2=101 arg3=102 arg4=103 arg5=104 > ^^^^ ^^^^
Ack, let's remove it. I will also remove the "task" argument.
