From: Steven Rostedt <[email protected]>

Currently there's an "out_reg:" label that gets jumped to if there's no
parameters to process. Instead, make it a proper "if (param) { }" block as
there's not much to do for the parameter processing, and remove the
"out_reg:" label.

Signed-off-by: Steven Rostedt (Google) <[email protected]>
---
 kernel/trace/trace_events.c | 28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 43e9545b5cf3..86db6ee6f26c 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -3799,24 +3799,22 @@ event_enable_func(struct trace_array *tr, struct 
ftrace_hash *hash,
 
        ret = -ENOMEM;
 
-       if (!param)
-               goto out_reg;
-
-       number = strsep(&param, ":");
+       if (param) {
+               number = strsep(&param, ":");
 
-       ret = -EINVAL;
-       if (!strlen(number))
-               goto out;
+               ret = -EINVAL;
+               if (!strlen(number))
+                       goto out;
 
-       /*
-        * We use the callback data field (which is a pointer)
-        * as our counter.
-        */
-       ret = kstrtoul(number, 0, &count);
-       if (ret)
-               goto out;
+               /*
+                * We use the callback data field (which is a pointer)
+                * as our counter.
+                */
+               ret = kstrtoul(number, 0, &count);
+               if (ret)
+                       goto out;
+       }
 
- out_reg:
        /* Don't let event modules unload while probe registered */
        ret = trace_event_try_get_ref(file->event_call);
        if (!ret) {
-- 
2.45.2



Reply via email to