On Thu, Feb 06, 2025 at 10:02:49AM +0100, Sebastian Andrzej Siewior wrote:
> On 2025-02-05 15:50:14 [-0800], Paul E. McKenney wrote:
> > diff --git a/include/linux/printk.h b/include/linux/printk.h
> > index 4217a9f412b2..d658d7e81bef 100644
> > --- a/include/linux/printk.h
> > +++ b/include/linux/printk.h
> > @@ -207,6 +207,7 @@ void printk_legacy_allow_panic_sync(void);
> > extern bool nbcon_device_try_acquire(struct console *con);
> > extern void nbcon_device_release(struct console *con);
> > void nbcon_atomic_flush_unsafe(void);
> > +bool pr_flush(int timeout_ms, bool reset_on_progress);
> …
> > diff --git a/kernel/reboot.c b/kernel/reboot.c
> > index a701000bab34..a84828d0757b 100644
> > --- a/kernel/reboot.c
> > +++ b/kernel/reboot.c
> > @@ -704,6 +704,7 @@ void kernel_power_off(void)
> > migrate_to_reboot_cpu();
> > syscore_shutdown();
> > pr_emerg("Power down\n");
> > + pr_flush(1000, 1);
>
> this could be true instead 1 given that the type is bool
Good point, and this matches other usage. Will fix on my next rebase.
Thanx, Paul
> > kmsg_dump(KMSG_DUMP_SHUTDOWN);
> > machine_power_off();
> > }
>
> Sebastian
