Hi,
Here is a series of patches to register fprobe only when the fprobe
event is enabled. Steve suggested the fprobe-events are always
registered when it is defined, even if it is disabled and that makes
system overhead. This series registeres the fprobes only when the event
is enabled.
NOTE: tracepoint has a AB-BA locking issue[*], so it is still enabled
when the event is defined. That should be eventually solved, but it may
need more complicated change. Thus this series focuses on registering
fprobe when the event is enabled.
(*) AB-BA lock if we enable tracepoint when enabling tprobe event:
[event enable]
__ftrace_event_enable_disable() ----> event_mutex
__regsiter_tracepoint_fprobe()
find_tracepoint()
for_each_module_tracepoint() ----> tracepoint_module_list_mutex
[module loading]
prepare_coming_module()
tracepoint_module_notify()
tracepoint_module_coming() ----> tracepoint_module_list_mutex
__tracepoint_probe_module_cb() ---> event_mutex
I have an idea to defer fprobe event enablement when module loading
so that we can avoid taking event_mutex in
__tracepoint_probe_module_cb(), but it needs to introduce another
list of tracepoint_user and another mutex.
Thank you,
---
Masami Hiramatsu (Google) (4):
tracing: tprobe-events: Remove mod field from tprobe-event
tracing: tprobe-events: Support multiple tprobes on the same tracepoint
tracing: fprobe-events: Register fprobe-events only when it is enabled
selftests: tracing: Enable fprobe events before checking enable_functions
include/linux/fprobe.h | 8
include/linux/module.h | 4
kernel/trace/fprobe.c | 29 +
kernel/trace/trace_fprobe.c | 490 +++++++++++++-------
.../ftrace/test.d/dynevent/add_remove_fprobe.tc | 30 +
5 files changed, 362 insertions(+), 199 deletions(-)
--
Masami Hiramatsu (Google) <mhira...@kernel.org>
