Re: [PATCHv3 perf/core 1/2] uprobes/x86: Add support to emulate nop instructions

[Oleg Nesterov]

On 04/14, Jiri Olsa wrote:
>
> @@ -840,6 +840,11 @@ static int branch_setup_xol_ops(struct arch_uprobe 
> *auprobe, struct insn *insn)
>       insn_byte_t p;
>       int i;
>  
> +     /* x86_nops[insn->length]; same as jmp with .offs = 0 */
> +     if (insn->length <= ASM_NOP_MAX &&
> +         !memcmp(insn->kaddr, x86_nops[insn->length], insn->length))
> +             goto setup;

Reviewed-by: Oleg Nesterov <o...@redhat.com>