From: Steven Rostedt <rost...@goodmis.org>

The per CPU "disabled" value was the original way to disable tracing when
the tracing subsystem was first created. Today, the ring buffer
infrastructure has its own way to disable tracing. In fact, things have
changed so much since 2008 that many things ignore the disable flag.

Do not bother setting the per CPU disabled flag of the array_buffer data
to use to determine what CPUs can write to the buffer and only rely on the
ring buffer code itself to disabled it.

Signed-off-by: Steven Rostedt (Google) <rost...@goodmis.org>
---
 kernel/trace/trace.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 490c24271a3d..395d1229da77 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -5081,7 +5081,6 @@ int tracing_set_cpumask(struct trace_array *tr,
                 */
                if (cpumask_test_cpu(cpu, tr->tracing_cpumask) &&
                                !cpumask_test_cpu(cpu, tracing_cpumask_new)) {
-                       atomic_inc(&per_cpu_ptr(tr->array_buffer.data, 
cpu)->disabled);
                        ring_buffer_record_disable_cpu(tr->array_buffer.buffer, 
cpu);
 #ifdef CONFIG_TRACER_MAX_TRACE
                        ring_buffer_record_disable_cpu(tr->max_buffer.buffer, 
cpu);
@@ -5089,7 +5088,6 @@ int tracing_set_cpumask(struct trace_array *tr,
                }
                if (!cpumask_test_cpu(cpu, tr->tracing_cpumask) &&
                                cpumask_test_cpu(cpu, tracing_cpumask_new)) {
-                       atomic_dec(&per_cpu_ptr(tr->array_buffer.data, 
cpu)->disabled);
                        ring_buffer_record_enable_cpu(tr->array_buffer.buffer, 
cpu);
 #ifdef CONFIG_TRACER_MAX_TRACE
                        ring_buffer_record_enable_cpu(tr->max_buffer.buffer, 
cpu);
-- 
2.47.2



Reply via email to