On Thu, 15 May 2025 01:49:55 +0530
Devaansh Kumar <devaanshk...@gmail.com> wrote:

> strncpy() is deprecated for NUL-terminated destination buffers and must
> be replaced by strscpy().
> 
> See issue: https://github.com/KSPP/linux/issues/90
> 
> Signed-off-by: Devaansh Kumar <devaanshk...@gmail.com>
> ---
>  kernel/trace/trace_events_hist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_events_hist.c 
> b/kernel/trace/trace_events_hist.c
> index 1260c23cfa5f..90a4e486fba8 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -5225,7 +5225,7 @@ static inline void add_to_key(char *compound_key, void 
> *key,
>               if (size > key_field->size - 1)
>                       size = key_field->size - 1;
>  
> -             strncpy(compound_key + key_field->offset, (char *)key, size);
> +             strscpy(compound_key + key_field->offset, (char *)key, size);
>       } else
>               memcpy(compound_key + key_field->offset, key, size);
>  }

Incorrect, and this is already fixed in next (at least it's in my 
ftrace/for-next branch).

  https://lore.kernel.org/20250403210637.1c477...@gandalf.local.home

-- Steve

Reply via email to