Hi MM folks,
Would you mind picking up this patch to remove some old tracepoints?
Liam has already given it a review.
Thanks,
Caleb
On Fri, Apr 11, 2025 at 10:23 AM Liam R. Howlett
<liam.howl...@oracle.com> wrote:
>
> * Caleb Sander Mateos <csan...@purestorage.com> [250411 12:18]:
> > The vma_mas_szero and vma_store tracepoints are unused since commit
> > fbcc3104b843 ("mmap: convert __vma_adjust() to use vma iterator").
> > Remove them so they are no longer listed as available tracepoints.
> >
>
> Thanks for doing this.
>
> Reviewed-by: Liam R. Howlett <liam.howl...@oracle.com>
>
> > Reported-by: Eric Mueller <emuel...@purestorage.com>
> > Signed-off-by: Caleb Sander Mateos <csan...@purestorage.com>
> > ---
> > include/trace/events/mmap.h | 52 -------------------------------------
> > 1 file changed, 52 deletions(-)
> >
> > diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> > index f8d61485de16..ee2843a5daef 100644
> > --- a/include/trace/events/mmap.h
> > +++ b/include/trace/events/mmap.h
> > @@ -41,62 +41,10 @@ TRACE_EVENT(vm_unmapped_area,
> > __entry->total_vm, __entry->flags, __entry->length,
> > __entry->low_limit, __entry->high_limit, __entry->align_mask,
> > __entry->align_offset)
> > );
> >
> > -TRACE_EVENT(vma_mas_szero,
> > - TP_PROTO(struct maple_tree *mt, unsigned long start,
> > - unsigned long end),
> > -
> > - TP_ARGS(mt, start, end),
> > -
> > - TP_STRUCT__entry(
> > - __field(struct maple_tree *, mt)
> > - __field(unsigned long, start)
> > - __field(unsigned long, end)
> > - ),
> > -
> > - TP_fast_assign(
> > - __entry->mt = mt;
> > - __entry->start = start;
> > - __entry->end = end;
> > - ),
> > -
> > - TP_printk("mt_mod %p, (NULL), SNULL, %lu, %lu,",
> > - __entry->mt,
> > - (unsigned long) __entry->start,
> > - (unsigned long) __entry->end
> > - )
> > -);
> > -
> > -TRACE_EVENT(vma_store,
> > - TP_PROTO(struct maple_tree *mt, struct vm_area_struct *vma),
> > -
> > - TP_ARGS(mt, vma),
> > -
> > - TP_STRUCT__entry(
> > - __field(struct maple_tree *, mt)
> > - __field(struct vm_area_struct *, vma)
> > - __field(unsigned long, vm_start)
> > - __field(unsigned long, vm_end)
> > - ),
> > -
> > - TP_fast_assign(
> > - __entry->mt = mt;
> > - __entry->vma = vma;
> > - __entry->vm_start = vma->vm_start;
> > - __entry->vm_end = vma->vm_end - 1;
> > - ),
> > -
> > - TP_printk("mt_mod %p, (%p), STORE, %lu, %lu,",
> > - __entry->mt, __entry->vma,
> > - (unsigned long) __entry->vm_start,
> > - (unsigned long) __entry->vm_end
> > - )
> > -);
> > -
> > -
> > TRACE_EVENT(exit_mmap,
> > TP_PROTO(struct mm_struct *mm),
> >
> > TP_ARGS(mm),
> >
> > --
> > 2.45.2
> >
