Can I get an acked-by, and I'll pull this in through my tree (with the other patches that remove unused events)?
Thanks, -- Steve On Thu, 29 May 2025 15:07:22 -0400 Steven Rostedt <rost...@goodmis.org> wrote: > From: Steven Rostedt <rost...@goodmis.org> > > When the dax_fault_actor() helper was factored out, it removed the calls > to the dax_pmd_insert_mapping event but never removed the event itself. As > events created do take up memory (roughly 5K), this is a waste as it is > never used. > > Remove the unused dax_pmd_insert_mapping trace event. > > Link: https://lore.kernel.org/all/20250529130138.544ff...@gandalf.local.home/ > > Fixes: c2436190e492 ("fsdax: factor out a dax_fault_actor() helper") > Signed-off-by: Steven Rostedt (Google) <rost...@goodmis.org> > --- > include/trace/events/fs_dax.h | 48 ----------------------------------- > 1 file changed, 48 deletions(-) > > diff --git a/include/trace/events/fs_dax.h b/include/trace/events/fs_dax.h > index 86fe6aecff1e..4d99ee3b62ea 100644 > --- a/include/trace/events/fs_dax.h > +++ b/include/trace/events/fs_dax.h > @@ -102,54 +102,6 @@ DEFINE_EVENT(dax_pmd_load_hole_class, name, \ > DEFINE_PMD_LOAD_HOLE_EVENT(dax_pmd_load_hole); > DEFINE_PMD_LOAD_HOLE_EVENT(dax_pmd_load_hole_fallback); > > -DECLARE_EVENT_CLASS(dax_pmd_insert_mapping_class, > - TP_PROTO(struct inode *inode, struct vm_fault *vmf, > - long length, pfn_t pfn, void *radix_entry), > - TP_ARGS(inode, vmf, length, pfn, radix_entry), > - TP_STRUCT__entry( > - __field(unsigned long, ino) > - __field(unsigned long, vm_flags) > - __field(unsigned long, address) > - __field(long, length) > - __field(u64, pfn_val) > - __field(void *, radix_entry) > - __field(dev_t, dev) > - __field(int, write) > - ), > - TP_fast_assign( > - __entry->dev = inode->i_sb->s_dev; > - __entry->ino = inode->i_ino; > - __entry->vm_flags = vmf->vma->vm_flags; > - __entry->address = vmf->address; > - __entry->write = vmf->flags & FAULT_FLAG_WRITE; > - __entry->length = length; > - __entry->pfn_val = pfn.val; > - __entry->radix_entry = radix_entry; > - ), > - TP_printk("dev %d:%d ino %#lx %s %s address %#lx length %#lx " > - "pfn %#llx %s radix_entry %#lx", > - MAJOR(__entry->dev), > - MINOR(__entry->dev), > - __entry->ino, > - __entry->vm_flags & VM_SHARED ? "shared" : "private", > - __entry->write ? "write" : "read", > - __entry->address, > - __entry->length, > - __entry->pfn_val & ~PFN_FLAGS_MASK, > - __print_flags_u64(__entry->pfn_val & PFN_FLAGS_MASK, "|", > - PFN_FLAGS_TRACE), > - (unsigned long)__entry->radix_entry > - ) > -) > - > -#define DEFINE_PMD_INSERT_MAPPING_EVENT(name) \ > -DEFINE_EVENT(dax_pmd_insert_mapping_class, name, \ > - TP_PROTO(struct inode *inode, struct vm_fault *vmf, \ > - long length, pfn_t pfn, void *radix_entry), \ > - TP_ARGS(inode, vmf, length, pfn, radix_entry)) > - > -DEFINE_PMD_INSERT_MAPPING_EVENT(dax_pmd_insert_mapping); > - > DECLARE_EVENT_CLASS(dax_pte_fault_class, > TP_PROTO(struct inode *inode, struct vm_fault *vmf, int result), > TP_ARGS(inode, vmf, result),
