On June 9, 2025 3:21:20 PM EDT, Matthew Wilcox <wi...@infradead.org> wrote: >On Mon, Jun 09, 2025 at 05:08:07PM +0000, Shivank Garg wrote: >> Replace open-coded folio reference count calculations with the >> folio_expected_ref_count() helper to improve code maintainability >> and reduce duplication. > >If it needs this much additional commentary, perhaps it's not actually >clearer? I don't know. I tend to over explain as I rather make it totally obvious what is happening. I wouldn't say excessive commentary is necessarily a sign that it's not clearer. Not knowing the code, the explanation makes sense to me. -- Steve
- [RFC] mm: use folio_expected_ref_count() helper for refe... Shivank Garg
- Re: [RFC] mm: use folio_expected_ref_count() helper... Matthew Wilcox
- Re: [RFC] mm: use folio_expected_ref_count() he... Steven Rostedt
- Re: [RFC] mm: use folio_expected_ref_count(... Matthew Wilcox
- Re: [RFC] mm: use folio_expected_ref_co... Steven Rostedt
- Re: [RFC] mm: use folio_expected_r... Shivank Garg
- Re: [RFC] mm: use folio_expected_ref_co... David Hildenbrand
- Re: [RFC] mm: use folio_expected_ref_count() helper... Alistair Popple
- Re: [RFC] mm: use folio_expected_ref_count() he... Shivank Garg
- Re: [RFC] mm: use folio_expected_ref_count() helper... David Hildenbrand
- Re: [RFC] mm: use folio_expected_ref_count() he... Shivank Garg