On Thu, 12 Jun 2025 19:16:33 -0700 Alexei Starovoitov <alexei.starovoi...@gmail.com> wrote:
> On Thu, Jun 12, 2025 at 3:20 PM Steven Rostedt <rost...@goodmis.org> wrote: > > > > From: Steven Rostedt <rost...@goodmis.org> > > > > The events xdp_cpumap_kthread, xdp_cpumap_enqueue and xdp_devmap_xmit are > > only called when CONFIG_BPF_SYSCALL is defined. As each event can take up > > to 5K regardless if they are used or not, it's best not to define them > > when they are not used. Add #ifdef around these events when they are not > > used. > > > > Acked-by: Jesper Dangaard Brouer <h...@kernel.org> > > Signed-off-by: Steven Rostedt (Google) <rost...@goodmis.org> > > --- > > Changes since v1: > > https://lore.kernel.org/20250612101612.3d450...@batman.local.home > > > > - Rebased on top of bpf-next > > We can certainly take it, but you mentioned you're working > on some patches that will warn when tracepoint is not used. > So do you need this to land sooner than the next merge window ? No. I plan on sending that code near the end of the next merge window to let these patches get in before they start to add warnings. I'm also going to wait till near the end of this cycle before I add that code to linux-next to keep the warnings happening there too soon. So, please take it. That way there's less likelihood of another conflict. Thanks, -- Steve