From: "Mike Rapoport (Microsoft)" <r...@kernel.org>

When execmem populates ROX cache it uses vmalloc(VM_ALLOW_HUGE_VMAP).
Although vmalloc falls back to allocating base pages if high order
allocation fails, it may happen that it still cannot allocate enough
memory.

Right now ROX cache is only used by modules and in majority of cases the
allocations happen at boot time when there's plenty of free memory, but
upcoming enabling ROX cache for ftrace and kprobes would mean that execmem
allocations can happen when the system is under memory pressure and a
failure to allocate large page worth of memory becomes more likely.

Fallback to regular vmalloc() if vmalloc(VM_ALLOW_HUGE_VMAP) fails.

Signed-off-by: Mike Rapoport (Microsoft) <r...@kernel.org>
---
 mm/execmem.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/mm/execmem.c b/mm/execmem.c
index 056d3caaf4a1..04c35c3a9361 100644
--- a/mm/execmem.c
+++ b/mm/execmem.c
@@ -291,6 +291,11 @@ static int execmem_cache_populate(struct execmem_range 
*range, size_t size)
 
        alloc_size = round_up(size, PMD_SIZE);
        p = execmem_vmalloc(range, alloc_size, PAGE_KERNEL, vm_flags);
+       if (!p) {
+               alloc_size = size;
+               p = execmem_vmalloc(range, alloc_size, PAGE_KERNEL, vm_flags);
+       }
+
        if (!p)
                return err;
 
@@ -462,7 +467,7 @@ void *execmem_alloc(enum execmem_type type, size_t size)
        bool use_cache = range->flags & EXECMEM_ROX_CACHE;
        unsigned long vm_flags = VM_FLUSH_RESET_PERMS;
        pgprot_t pgprot = range->pgprot;
-       void *p;
+       void *p = NULL;
 
        size = PAGE_ALIGN(size);
 
-- 
2.47.2


Reply via email to