On Tue, Jul 15, 2025 at 05:24:11PM +0200, Gabriele Monaco wrote: > Right, I didn't make it obvious in the commit description since I > thought it wasn't too important. > Those are the monitors whose lines are going to be longer than 100 > columns later in the series. > > Changing it there saves a bit of complication in the next patches, > where I only add lines for new events instead of splitting the line > /and/ adding the events.
Ah, that makes sense. I thought the script went wild. > Do you think I should mention this in the commit description? A maintainer once told me that the rule is "one thing per patch", not "half a thing per patch". This does make the diff easier to read in the later patch, but I think it is not worth it. For this case, I can easily review the later patches by regenerate the files. So I suggest dropping these. Best regards, Nam
