Hi Linus,
On 7/18/25 12:05 AM, Linus Torvalds wrote:
On Wed, 16 Jul 2025 at 13:47, Andrii Nakryiko <andrii.nakry...@gmail.com> wrote:
But given how frequently task->comm is referenced (pretty much any
profiler or tracer will capture this), it's just the widespread nature
of accessing task->comm in BPF programs/scripts that will cause a lot
of adaptation churn. And given the reason for renaming was to catch
missing cases during refactoring, my ask was to do this renaming
locally, validate all kernel code was modified, and then switch the
field name back to "comm" (which you already did, so the remaining
part would be just to rename comm_str back to comm).
Yes. Please.
Renaming the field is a great way to have the compiler scream loudly
of any missed cases, but keep it local (without committing it), and
rename it back after checking everything.
Sure, I will send v6 with the above suggested change.
Thanks.
