This patchset fixes the handling of delegated timestamps in nfsd. This one also adopts Neil's suggestopn to use FMODE_NOCMTIME to freeze timestamp updates while there is a WRITE_ATTRS delegation outstanding.
Most of these patches are identical to the last set. I dropped the patch that removes inode_set_ctime_deleg(), and reworked the logic in setattr_copy() and friends to accomodate. The last patch in the series is new. That one adds FMODE_NOCMTIME to the file while a WRITE_ATTRS delegation is in force, and adds a mechanism to ensure that the timestamps gets updated appropriately if the client never sends a SETATTR with updated timestamps in it. That should ensure that the ctime never rolls backward. This patchset also leaves inode_set_ctime_deleg() in place. That's probably overengineered if we don't need to worry about ctime updates from the client racing with ctime updates due to writes anymore, but we can simplify it later if so. The series passes the gitr testsuite in the "stress" configuration. Signed-off-by: Jeff Layton <jlay...@kernel.org> --- Changes in v4: - Use FMODE_NOCMTIME to freeze timestamp updates on write - drop patch that removes inode_set_ctime_deleg() - rework logic in setattr_copy() - Link to v3: https://lore.kernel.org/r/20250727-nfsd-testing-v3-0-8dc2aafb1...@kernel.org Changes in v3: - split out decoder fix into separate patch - add Fixes: tags - Link to v2: https://lore.kernel.org/r/20250726-nfsd-testing-v2-0-f45923db2...@kernel.org Changes in v2: - add ATTR_CTIME_SET and remove inode_set_ctime_deleg() - track original timestamps in struct nfs4_delegation - fix delegated timestamp updates to respect saved timestamps - Link to v1: https://lore.kernel.org/r/20250722-nfsd-testing-v1-0-31321c7fc...@kernel.org --- Jeff Layton (8): nfsd: fix assignment of ia_ctime.tv_nsec on delegated mtime update nfsd: ignore ATTR_DELEG when checking ia_valid before notify_change() vfs: add ATTR_CTIME_SET flag nfsd: use ATTR_CTIME_SET for delegated ctime updates nfsd: track original timestamps in nfs4_delegation nfsd: fix SETATTR updates for delegated timestamps nfsd: fix timestamp updates in CB_GETATTR nfsd: freeze c/mtime updates with outstanding WRITE_ATTRS delegation fs/attr.c | 44 ++++++++++++--------------- fs/nfsd/nfs4proc.c | 55 ++++++++++++++++++++++++++++++++-- fs/nfsd/nfs4state.c | 86 ++++++++++++++++++++++++++++++++++++++++------------- fs/nfsd/nfs4xdr.c | 5 ++-- fs/nfsd/state.h | 12 +++++++- fs/nfsd/vfs.c | 2 +- include/linux/fs.h | 1 + 7 files changed, 153 insertions(+), 52 deletions(-) --- base-commit: b05f077b59098b4760e3f675b00a4e6a1ad4b0ad change-id: 20250722-nfsd-testing-5e861a3cf3a0 Best regards, -- Jeff Layton <jlay...@kernel.org>
