On Thu, Jul 31, 2025 at 10:02:19AM +0200, Gabriele Monaco wrote: > You don't really need to follow to the ID/IMPLICIT convention here. > > These LTL per-cpu monitors are, in fact, not implicit since they do > have an id (the CPU), implicit makes sense with the current > implementation of da_get_monitor that uses the current CPU (doesn't > have to stay that way, but there was no need to change so far). > > If you don't want to get rid of the task's comm in the tracepoint (and > unify both with an integer id, like with DA), I'd suggest you use > different names like CONFIG_LTL_MON_EVENTS_TASK (in fact that doesn't > just have an ID) and CONFIG_LTL_MON_EVENTS_CPU (or even > CONFIG_LTL_MON_EVENTS_ID, for this it actually makes sense). > > I'd prefer it as general as possible to ease new monitor types, but to > be real picky the LTLs per-task are not ID and the per-cpu are not > IMPLICIT. > > The id field is what the rv userspace tool uses to differentiate > monitor types, by the way.
Ah, these names didn't make sense to me. But DA use them, so I was "whatever". Thanks for the explanation, let's use the _CPU names instead. > > +#endif /* CONFIG_LTL_MON_EVENTS_IMPLICIT */ > > + > > #endif /* CONFIG_LTL_MON_EVENTS_ID */ > > Also, I'm not sure if that was intended, but > CONFIG_LTL_MON_EVENTS_IMPLICIT gets compiled only with > CONFIG_LTL_MON_EVENTS_ID. That was certainly not intended. Nam
