On Thu, 21 Aug 2025 at 06:58, Crystal Wood <crw...@redhat.com> wrote:
> The hist members were very similar between timerlat and top, so
> just use one common hist struct.
...
> @@ -27,4 +38,10 @@ struct common_params {
...
> + struct hist_params hist;
Moving `hist_params` into `common_params` could lead to
the `common_params` struct becoming a "god object" antipattern.
The `common_params` struct is intended to be tool-agnostic.
I suggest we use `hist_params` within the tools themselves,
rather than in `common_params`.
Thanks,
Costa
