From: Masami Hiramatsu (Google) <[email protected]>

The 'ret' local variable in fprobe_remove_node_in_module() was used
for checking the error state in the loop, but commit dfe0d675df82
("tracing: fprobe: use rhltable for fprobe_ip_table") removed the loop.
So we don't need it anymore.

Fixes: dfe0d675df82 ("tracing: fprobe: use rhltable for fprobe_ip_table")
Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
---
 kernel/trace/fprobe.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/kernel/trace/fprobe.c b/kernel/trace/fprobe.c
index 6a205903b1ed..12ec194fdfed 100644
--- a/kernel/trace/fprobe.c
+++ b/kernel/trace/fprobe.c
@@ -457,8 +457,6 @@ static int fprobe_addr_list_add(struct fprobe_addr_list 
*alist, unsigned long ad
 static void fprobe_remove_node_in_module(struct module *mod, struct 
fprobe_hlist_node *node,
                                         struct fprobe_addr_list *alist)
 {
-       int ret = 0;
-
        if (!within_module(node->addr, mod))
                return;
        if (delete_fprobe_node(node))
@@ -467,8 +465,7 @@ static void fprobe_remove_node_in_module(struct module 
*mod, struct fprobe_hlist
         * If failed to update alist, just continue to update hlist.
         * Therefore, at list user handler will not hit anymore.
         */
-       if (!ret)
-               ret = fprobe_addr_list_add(alist, node->addr);
+       fprobe_addr_list_add(alist, node->addr);
 }
 
 /* Handle module unloading to manage fprobe_ip_table. */


Reply via email to