Track the union of the requested and supported directory attributes in
the delegation.

Signed-off-by: Jeff Layton <jlay...@kernel.org>
---
 fs/nfsd/nfs4proc.c  |  7 ++++---
 fs/nfsd/nfs4state.c | 14 +++++++++++++-
 fs/nfsd/state.h     |  2 ++
 3 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 
774d18dd2f1a31d299a8426c3462847de6c88115..187daf86e62f7c94892a3b30bf2eb37bb9863595
 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -2335,9 +2335,10 @@ nfsd4_verify(struct svc_rqst *rqstp, struct 
nfsd4_compound_state *cstate,
        return status == nfserr_same ? nfs_ok : status;
 }
 
-#define SUPPORTED_NOTIFY_MASK  (BIT(NOTIFY4_REMOVE_ENTRY) |    \
-                                BIT(NOTIFY4_ADD_ENTRY) |       \
-                                BIT(NOTIFY4_RENAME_ENTRY) |    \
+#define SUPPORTED_NOTIFY_MASK  (BIT(NOTIFY4_CHANGE_DIR_ATTRS) |        \
+                                BIT(NOTIFY4_REMOVE_ENTRY) |            \
+                                BIT(NOTIFY4_ADD_ENTRY) |               \
+                                BIT(NOTIFY4_RENAME_ENTRY) |            \
                                 BIT(NOTIFY4_GFLAG_EXTEND))
 
 static __be32
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 
368face4d0b7001914b209b858dc1baa366535f6..2381dbb2e48290debf28bbd35d0b9a4bb677ac07
 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -9658,6 +9658,15 @@ nfsd4_deleg_getattr_conflict(struct svc_rqst *rqstp, 
struct dentry *dentry,
                                 FATTR4_WORD1_TIME_MODIFY |     \
                                 FATTR4_WORD1_TIME_CREATE)
 
+#define GDD_WORD0_DIR_ATTRS    (FATTR4_WORD0_CHANGE |          \
+                                FATTR4_WORD0_SIZE)
+
+#define GDD_WORD1_DIR_ATTRS    (FATTR4_WORD1_NUMLINKS |        \
+                                FATTR4_WORD1_SPACE_USED |      \
+                                FATTR4_WORD1_TIME_ACCESS |     \
+                                FATTR4_WORD1_TIME_METADATA |   \
+                                FATTR4_WORD1_TIME_MODIFY)
+
 /**
  * nfsd_get_dir_deleg - attempt to get a directory delegation
  * @cstate: compound state
@@ -9704,10 +9713,13 @@ nfsd_get_dir_deleg(struct nfsd4_compound_state *cstate,
        if (!dp)
                goto out_delegees;
 
+       dp->dl_notify_mask = gdd->gddr_notification[0];
        dp->dl_child_attrs[0] = gdd->gdda_child_attributes[0] & 
GDD_WORD0_CHILD_ATTRS;
        dp->dl_child_attrs[1] = gdd->gdda_child_attributes[1] & 
GDD_WORD1_CHILD_ATTRS;
+       dp->dl_dir_attrs[0] = gdd->gdda_dir_attributes[0] & GDD_WORD0_DIR_ATTRS;
+       dp->dl_dir_attrs[1] = gdd->gdda_dir_attributes[1] & GDD_WORD1_DIR_ATTRS;
 
-       fl = nfs4_alloc_init_lease(dp, gdd->gddr_notification[0]);
+       fl = nfs4_alloc_init_lease(dp, dp->dl_notify_mask);
        if (!fl)
                goto out_put_stid;
 
diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h
index 
73869ae25bcdf63cc29f9ba49bdac20e21a812bd..946753d3ab6730892ba827151f2008afb46dcb57
 100644
--- a/fs/nfsd/state.h
+++ b/fs/nfsd/state.h
@@ -283,7 +283,9 @@ struct nfs4_delegation {
        struct timespec64       dl_ctime;
 
        /* For dir delegations */
+       uint32_t                dl_notify_mask;
        uint32_t                dl_child_attrs[2];
+       uint32_t                dl_dir_attrs[2];
 };
 
 static inline bool deleg_is_read(u32 dl_type)

-- 
2.51.0


Reply via email to