Gabriele Monaco <[email protected]> writes: > On Thu, 2025-10-02 at 13:03 +0200, Nam Cao wrote: >> Gabriele Monaco <[email protected]> writes: >> >> > Currently the automata parser assumes event strings don't have any >> > space, this stands true for event names, but can be a wrong assumption >> > if we want to store other information in the event strings (e.g. >> > constraints for hybrid automata). >> > >> > Adapt the parser logic to allow spaces in the event strings. >> >> I probably misunderstand something, but isn't the description >> misleading? After reading this description, I expect the patch to ignore >> spaces or something similar. But from my understanding, the script only >> allowed a single event, and this patch allows conditions as well. > > The script allows multiple events, all separated by \n, strictly speaking > there > is nothing saying spaces are not allowed in event names, but the parser breaks > if there's any space. > > This patch allows spaces in event names, conditions (separated by a ; ) are > not > supported yet. > >> Shouldn't this be squashed to the next patch? > > I kept it separated to avoid pushing too many changes in the next one, which > mostly adds new functionality (and lines) instead of changing the current > ones. > > Apparently that didn't make it any clearer, and there isn't really any use > case > needing event names with spaces, so if it looks cleaner to you I can just > squash > it.
Nah, you can keep it. I was just confused. Now I looked again, it starts to make sense. Reviewed-by: Nam Cao <[email protected]> I am thinking about converting the entire thing to be ply-based (after we are done with this series). It should make things easier to follow. Would you object that? Nam
