Re: [RFC] Revert "perf/x86: Always store regs->ip in perf_callchain_kernel()"

[Song Liu]

On Tue, Sep 30, 2025 at 6:29 AM Jiri Olsa <jo...@kernel.org> wrote:
>
> This reverts commit 83f44ae0f8afcc9da659799db8693f74847e66b3.
>
> hi,
> non hw events store first stack trace entry twice:
>
>         bpf_prog_2beb79c650d605dd_rawtracepoint_sched_process_exec_1+324
>         bpf_prog_2beb79c650d605dd_rawtracepoint_sched_process_exec_1+324
>         bpf_trace_run3+138
>         bprm_execve+1191
>         do_execveat_common.isra.0+404
>         __x64_sys_execve+56
>         do_syscall_64+130
>         entry_SYSCALL_64_after_hwframe+118
>
> I traced it to [1] from 2019, which stores regs->ip implicitly to fix
> raw tracepoints stacktrace. Revert does not seem to break raw tp
> stacktrace for me. Song, any idea? I know it's long time ;-)

I cannot recall the original issue.

I tried the revert with multiple different tests. Everything seems to
work fine. I guess we can ship this revert.

Thanks for the fix!
Song

Acked-by: Song Liu <s...@kernel.org>