From: Masami Hiramatsu (Google) <[email protected]>

Since wprobe uses IS_ERR() for per-cpu pointer, it failed to build.

/tmp/next/build/kernel/trace/trace_wprobe.c: In function 
'__register_trace_wprobe':
/tmp/next/build/kernel/trace/trace_wprobe.c:176:20: error: cast to generic 
address space pointer from disjoint '__seg_gs' address space pointer [-Werror]
  176 |         if (IS_ERR((void * __force)tw->bp_event)) {
      |                    ^
/tmp/next/build/kernel/trace/trace_wprobe.c:177:35: error: cast to generic 
address space pointer from disjoint '__seg_gs' address space pointer [-Werror]
  177 |                 int ret = PTR_ERR((void * __force)tw->bp_event);
      |                                   ^

Use IS_ERR_PCPU() instead.

Reported-by: Mark Brown <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Suggested-by: Linus Torvalds <[email protected]>
Signed-off-by: Masami Hiramatsu (Google) <[email protected]>
---
 - Confirmed that `make allmodconfig && make` passed on x86_64 and arm64.
---
 kernel/trace/trace_wprobe.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_wprobe.c b/kernel/trace/trace_wprobe.c
index 4b00a8e917c1..aa8ef173528b 100644
--- a/kernel/trace/trace_wprobe.c
+++ b/kernel/trace/trace_wprobe.c
@@ -173,7 +173,7 @@ static int __register_trace_wprobe(struct trace_wprobe *tw)
        attr.bp_type = tw->type;
 
        tw->bp_event = register_wide_hw_breakpoint(&attr, wprobe_perf_handler, 
tw);
-       if (IS_ERR((void * __force)tw->bp_event)) {
+       if (IS_ERR_PCPU((void * __force)tw->bp_event)) {
                int ret = PTR_ERR((void * __force)tw->bp_event);
 
                tw->bp_event = NULL;


Reply via email to