Hi Steven, út 7. 10. 2025 v 11:53 odesílatel Tomas Glozar <[email protected]> napsal: > > Commit 8d933d5c89e8 ("rtla/timerlat: Add continue action") moved the > code performing on-threshold actions (enabled through --on-threshold > option) to inside the RTLA main loop. > > The condition in the loop does not check whether the threshold was > actually exceeded or if stop tracing was requested by the user through > SIGINT or duration. This leads to a bug where on-threshold actions are > always performed, even when the threshold was not hit. > > (BPF mode is not affected, since it uses a different condition in the > while loop.) > > Add a condition that checks for !stop_tracing before executing the > actions. Also, fix incorrect brackets in hist_main_loop to match the > semantics of top_main_loop. > > Fixes: 8d933d5c89e8 ("rtla/timerlat: Add continue action") > Fixes: 2f3172f9dd58 ("tools/rtla: Consolidate code between osnoise/timerlat > and hist/top") > Signed-off-by: Tomas Glozar <[email protected]> > Reviewed-by: Crystal Wood <[email protected]> > --- > v2: > - add one more patch fixing a bug noticed by Crystal in context of > the following one (doing v2 just to avoid conflicts, the first two > patches were not changed) > > tools/tracing/rtla/src/common.c | 24 +++++++++++++++--------- > 1 file changed, 15 insertions(+), 9 deletions(-) >
It seems that this patchset containing fixes for recently merged RTLA code consolidation [1] has no further comments. Could you take it? (Unless you have any comments, of course.) [1] https://lore.kernel.org/linux-trace-kernel/[email protected]/T/ Thanks, Tomas
