On Mon, 2025-10-06 at 16:26 +0200, Tomas Glozar wrote:
> In non-BPF mode, it takes up to 1 second for RTLA to notice that tracing
> has been stopped. That means that action tests cannot have a 1 second
> duration, as the SIGALRM will be racing with the threshold overflow.
>
> Previously, non-BPF mode actions were buggy and always executed
> the action, even when stopping on duration or SIGINT, preventing
> this issue from manifesting. Now that this has been fixed, the tests
> have become flaky, and this has to be adjusted.
>
> Fixes: 4e26f84abfb ("rtla/tests: Add tests for actions")
> Fixes: 05b7e10687c ("tools/rtla: Add remaining support for osnoise actions")
> Signed-off-by: Tomas Glozar <[email protected]>
> ---
> tools/tracing/rtla/tests/osnoise.t | 4 ++--
> tools/tracing/rtla/tests/timerlat.t | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/tracing/rtla/tests/osnoise.t
> b/tools/tracing/rtla/tests/osnoise.t
> index e3c89d45a6bb..08196443fef1 100644
> --- a/tools/tracing/rtla/tests/osnoise.t
> +++ b/tools/tracing/rtla/tests/osnoise.t
> @@ -39,9 +39,9 @@ check "hist stop at failed action" \
> check "top stop at failed action" \
> "timerlat top -T 2 --on-threshold shell,command='echo -n abc; false'
> --on-threshold shell,command='echo -n defgh'" 2 "^abc" "defgh"
> check "hist with continue" \
> - "osnoise hist -S 2 -d 1s --on-threshold shell,command='echo TestOutput'
> --on-threshold continue" 0 "^TestOutput$"
> + "osnoise hist -S 2 -d 5s --on-threshold shell,command='echo TestOutput'
> --on-threshold continue" 0 "^TestOutput$"
> check "top with continue" \
> - "osnoise top -q -S 2 -d 1s --on-threshold shell,command='echo
> TestOutput' --on-threshold continue" 0 "^TestOutput$"
> + "osnoise top -q -S 2 -d 5s --on-threshold shell,command='echo
> TestOutput' --on-threshold continue" 0 "^TestOutput$"
Not related to this patch other than noticing it via quoted context, but
I spent about a minute trying to figure out why "top stop at failed
action" uses -T instead of -S here, before noticing that it's also
invoking timerlat. :-P
-Crystal
