Re: [PATCH v3 13/16] blktrace: add block trace commands for zone operations

[Johannes Thumshirn]

On 10/16/25 9:09 AM, Christoph Hellwig wrote:
> On Wed, Oct 15, 2025 at 12:54:32PM +0200, Johannes Thumshirn wrote:
>> Add block trace commands for zone operations.
>>
>> Signed-off-by: Johannes Thumshirn <johannes.thumsh...@wdc.com>
>> ---
>>   include/uapi/linux/blktrace_api.h | 13 +++++++++++--
>>   kernel/trace/blktrace.c           | 25 +++++++++++++++++++++----
>>   2 files changed, 32 insertions(+), 6 deletions(-)
>>
>> diff --git a/include/uapi/linux/blktrace_api.h 
>> b/include/uapi/linux/blktrace_api.h
>> index 3a771b9802aa..925f78af939e 100644
>> --- a/include/uapi/linux/blktrace_api.h
>> +++ b/include/uapi/linux/blktrace_api.h
>> @@ -26,11 +26,20 @@ enum blktrace_cat {
>>      BLK_TC_DRV_DATA = 1 << 14,      /* binary per-driver data */
>>      BLK_TC_FUA      = 1 << 15,      /* fua requests */
>>   
>> -    BLK_TC_END      = 1 << 15,      /* we've run out of bits! */
>> +    BLK_TC_END_V1   = 1 << 15,      /* we've run out of bits! */
>> +
>> +    BLK_TC_ZONE_APPEND      = 1ull << 16,   /* zone append */
> Should BLK_TC_ZONE_APPEND be BLK_TC_END_V1?  Or is BLK_TC_END_V1 going
> ot be used as the catchall for everything not reported in v1?
BLK_TC_END_V1 is equal to BLK_TC_FUA, but at the moment we're not doing 
anything with it. I'll add a WARN_ON() in case bt->version 1 is 
requested and a action > BLK_TC_END_V1 is passed in.